Coupling LandModel with full surface energy balance to SpeedyWeather#110
Coupling LandModel with full surface energy balance to SpeedyWeather#110bgroenks96 wants to merge 28 commits intomainfrom
LandModel with full surface energy balance to SpeedyWeather#110Conversation
Also use as default scheme for bare ground evaporation
|
@milankl Since @maximilian-gelbrecht is on vacation, it would be great if you could approve this PR. |
|
@maximilian-gelbrecht and @milankl I have verified that the coupled model runs for up to 1 month of simulated time without errors, though I did not check the output. This is without the Richard's equation soil hydrology since this currently has problems unless you reduce the step size to an unbearably small number (like <10 seconds). This is, to some extent, expected; Richards' equation really needs implicit timestepping to be efficient. |
milankl
left a comment
There was a problem hiding this comment.
Just some comments from my side skimming through!!!
|
Do you want to merge this PR first, and then in a follow up adjust to Speedy 0.19, or still do that here? I am also happy to help with that adjustment. |
|
#114 already updates to Speedy v0.19 |
This PR updates the old SpeedyWeather script for the
PrimitiveDryModelair-soil temperature coupling and adds a new script with prototype coupling to aPrimitiveWetModelvia the full SEB.In the process of implementing this, I am also fixing bugs in the surface energy/water flux calculations.
G = R_net + H_s + H_lcorresponding to balance equationR_net + H_s + H_l - G = 0with all fluxes positive upwards (towards the atmosphere).SoilMoistureResistanceFactoris now the default choice forBareGroundEvaporation.